commit d01c63748cd1b4f3b3201504f6d858936a5cd348
author Tim Edwards <tim@opencircuitdesign.com> Wed Oct 28 13:40:03 2020 -0400
committer Ahmed Ghazy <ax3ghazy@aucegypt.edu> Wed Oct 28 22:58:29 2020 +0200
tree 0d76f16f945d7c9139e961fa03e5f87228b0e670
parent 22d29d6e8973054c55f7832e248749a36388bd27

Modified the mprj_ctrl.v verilog to be completely clear about how
many bits are set to zero for each of the contributers to the
iomem_rdata_pre vector.

verilog/dv/caravel/mgmt_soc/timer2/Makefile

diff --git a/verilog/dv/caravel/mgmt_soc/timer2/Makefile b/verilog/dv/caravel/mgmt_soc/timer2/Makefile
index 4255a9b..3feaad7 100644
--- a/verilog/dv/caravel/mgmt_soc/timer2/Makefile
+++ b/verilog/dv/caravel/mgmt_soc/timer2/Makefile
@@ -15,7 +15,7 @@
 hex:  ${PATTERN:=.hex}
 
 %.vvp: %_tb.v %.hex
-	iverilog -DFUNCTIONAL -I $(BEHAVIOURAL_MODELS) \
+	iverilog -Wall -DFUNCTIONAL -I $(BEHAVIOURAL_MODELS) \
 	-I $(PDK_PATH) -I $(IP_PATH) -I $(RTL_PATH) \
 	$< -o $@
 

verilog/rtl/mprj_ctrl.v

diff --git a/verilog/rtl/mprj_ctrl.v b/verilog/rtl/mprj_ctrl.v
index 0f385de..5ca0553 100644
--- a/verilog/rtl/mprj_ctrl.v
+++ b/verilog/rtl/mprj_ctrl.v
@@ -122,6 +122,7 @@
     wire [IO_WORDS-1:0] io_data_sel;	// wishbone selects
     wire pwr_data_sel;
     wire xfer_sel;
+    wire busy;
     wire [`MPRJ_IO_PADS-1:0] io_ctrl_sel;
     wire [31:0] iomem_rdata_pre;
 
@@ -164,18 +165,20 @@
 
     assign selected = xfer_sel || pwr_data_sel || (|io_data_sel) || (|io_ctrl_sel);
 
-    assign iomem_rdata_pre = (selected == 0) ? 0 :
+    assign iomem_rdata_pre = (selected == 0) ? 'b0 :
 			     (xfer_sel) ? {31'b0, busy} : 
-			     (pwr_data_sel) ? pwr_ctrl_out :
-			     'bz;
+			     (pwr_data_sel) ? {{(32-`MPRJ_PWR_PADS){1'b0}},
+					pwr_ctrl_out} : 'bz;
 
     generate 
         for (i=0; i<IO_WORDS; i=i+1) begin
-	    assign iomem_rdata_pre = (io_data_sel[i]) ?  mgmt_gpio_in[`wtop:`wbot] : 'bz;
+	    assign iomem_rdata_pre = (io_data_sel[i]) ?
+			{{(31-`rtop){1'b0}}, mgmt_gpio_in[`wtop:`wbot]} : 'bz;
 	end
 
         for (i=0; i<`MPRJ_IO_PADS; i=i+1) begin
-             assign iomem_rdata_pre = (io_ctrl_sel[i]) ? io_ctrl[i] : 'bz;
+             assign iomem_rdata_pre = (io_ctrl_sel[i]) ?
+			{{(32-IO_CTRL_BITS){1'b0}}, io_ctrl[i]} : 'bz;
 	end
     endgenerate
 
@@ -272,7 +275,6 @@
     reg [IO_CTRL_BITS-1:0] serial_data_staging;
 
     wire       serial_data_out;
-    wire       busy;
 
     assign serial_data_out = serial_data_staging[IO_CTRL_BITS-1];
     assign busy = (xfer_state != `IDLE);